Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

feat: product categories page #890

Closed
wants to merge 30 commits into from
Closed

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Feb 8, 2023

What:

  • an empty category index page for product categories
  • create category flow with fade modal

Why:

Product categories feature UI completeness.

How:

  • Sidebar with new menu item for categories
  • Category Route
  • Category Index Page in empty state
  • BodyCard changed to accept flexible height & border

Visuals:
Screenshot 2023-02-08 at 18 29 20


RESOLVES CORE-1077
RESOLVES CORE-1078
RESOLVES CORE-1200
RESOLVES CORE-1211

@vercel
Copy link

vercel bot commented Feb 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 9:44PM (UTC)
typeormv3 ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 9:44PM (UTC)

@netlify
Copy link

netlify bot commented Feb 8, 2023

Deploy Preview for nostalgic-booth-1cf149 failed.

Name Link
🔨 Latest commit 46f7e62
🔍 Latest deploy log https://app.netlify.com/sites/nostalgic-booth-1cf149/deploys/63ff8a59383e0b0007f51e07

@josetr
Copy link
Contributor

josetr commented Feb 13, 2023

I think I prefer a nested menu, similar to how Shopify does it. Perhaps moving the "Settings" item to the bottom would help too.

@riqwan riqwan changed the base branch from develop to feat/categories-list-page-empty March 2, 2023 07:59
src/pages/a.jsx Outdated
@@ -19,6 +19,7 @@ import Pricing from "../domain/pricing"
import ProductsRoute from "../domain/products"
import ProductCategories from "../domain/product-categories"
import PublishableApiKeys from "../domain/publishable-api-keys"
import ProductCategories from "../domain/product-categories"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: Remove duplicate import

@riqwan
Copy link
Contributor Author

riqwan commented Mar 6, 2023

closing in favor of medusajs/medusa#3399

@riqwan riqwan closed this Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants