This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for nostalgic-booth-1cf149 failed.
|
riqwan
force-pushed
the
feat/categories-empty-state
branch
from
February 8, 2023 17:27
ac772ae
to
f8689fa
Compare
I think I prefer a nested menu, similar to how Shopify does it. Perhaps moving the "Settings" item to the bottom would help too. |
fPolic
changed the title
feat: add empty page state for product categories
feat: product categories page
Feb 15, 2023
olivermrbl
reviewed
Mar 2, 2023
src/pages/a.jsx
Outdated
@@ -19,6 +19,7 @@ import Pricing from "../domain/pricing" | |||
import ProductsRoute from "../domain/products" | |||
import ProductCategories from "../domain/product-categories" | |||
import PublishableApiKeys from "../domain/publishable-api-keys" | |||
import ProductCategories from "../domain/product-categories" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: Remove duplicate import
closing in favor of medusajs/medusa#3399 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Why:
Product categories feature UI completeness.
How:
Visuals:
RESOLVES CORE-1077
RESOLVES CORE-1078
RESOLVES CORE-1200
RESOLVES CORE-1211